]> www.infradead.org Git - users/jedix/linux-maple.git/commit
CIFS: Do not reset lease state to NONE on lease break
authorPavel Shilovsky <piastryyy@gmail.com>
Wed, 13 Feb 2019 23:43:08 +0000 (15:43 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 13:35:18 +0000 (14:35 +0100)
commitfe0c218ef467433f908ed185474b30f969f2b425
treef430048581552c1e90778a84a31e168fb1a8564a
parent7976a8bf674e29084e659155b5791eec88e59542
CIFS: Do not reset lease state to NONE on lease break

commit 7b9b9edb49ad377b1e06abf14354c227e9ac4b06 upstream.

Currently on lease break the client sets a caching level twice:
when oplock is detected and when oplock is processed. While the
1st attempt sets the level to the value provided by the server,
the 2nd one resets the level to None unconditionally.
This happens because the oplock/lease processing code was changed
to avoid races between page cache flushes and oplock breaks.
The commit c11f1df5003d534 ("cifs: Wait for writebacks to complete
before attempting write.") fixed the races for oplocks but didn't
apply the same changes for leases resulting in overwriting the
server granted value to None. Fix this by properly processing
lease breaks.

Signed-off-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/smb2misc.c
fs/cifs/smb2ops.c