]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drivers/net/cnic.c: remove invalid reference to list iterator variable
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 8 Jul 2012 01:37:43 +0000 (01:37 +0000)
committerJoe Jin <joe.jin@oracle.com>
Tue, 28 Aug 2012 07:23:16 +0000 (15:23 +0800)
commitfda5c7e55a50f26e4ad263da6169d48b13b8e68f
tree5ceaee079def87b1612199bf9c849a7f77e5d40d
parent1305becd7afc8d94d0073d8710d16d10feb08a87
drivers/net/cnic.c: remove invalid reference to list iterator variable

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  There does not seem to be a meaningful value to
provide to netdev_warn.  Replace with pr_warn, since pr_err is used
elsewhere.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

(cherry picked from commit 022f09784b85396b4ceba954ce28e50de4882281)
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/net/cnic.c