]> www.infradead.org Git - users/jedix/linux-maple.git/commit
phy: stm32: Fix constant-value overflow assertion
authorChristian Bruel <christian.bruel@foss.st.com>
Mon, 10 Feb 2025 10:35:15 +0000 (11:35 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 10 Feb 2025 16:56:07 +0000 (22:26 +0530)
commitfd75f371f3a1b04a33d2e750363d6ad76abf734e
tree89b284de5f0e9f5a8c4114f038d91e4fad4129be
parent3126ea9be66b53e607f87f067641ba724be24181
phy: stm32: Fix constant-value overflow assertion

Rework the workaround as the lookup tables always fits into the bitfield,
and the default values are defined by the hardware and cannot be 0:

Guard against false positive with a WARN_ON check to make the compiler
happy: The offset range is pre-checked against the sorted imp_lookup_table
values and overflow should not happen and would be caught by a warning and
return in error.

Also guard against a true positive found during the max_vswing lookup, as a
max vswing value can be 802000 or 803000 microvolt depending on the current
impedance. Therefore set the default impedence index.

Fixes: 2de679ecd724 ("phy: stm32: work around constant-value overflow assertion")
Signed-off-by: Christian Bruel <christian.bruel@foss.st.com>
Link: https://lore.kernel.org/r/20250210103515.2598377-1-christian.bruel@foss.st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/st/phy-stm32-combophy.c