]> www.infradead.org Git - users/dwmw2/linux.git/commit
ptp: Ensure info->enable callback is always set
authorThomas Weißschuh <linux@weissschuh.net>
Thu, 23 Jan 2025 07:22:40 +0000 (08:22 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 27 Jan 2025 22:29:25 +0000 (14:29 -0800)
commitfd53aa40e65f518453115b6f56183b0c201db26b
tree657f4f8265f4955b39dac506ce72328d16e2e244
parentcde5959913b713eecee44451c9bb3141e625a8d8
ptp: Ensure info->enable callback is always set

The ioctl and sysfs handlers unconditionally call the ->enable callback.
Not all drivers implement that callback, leading to NULL dereferences.
Example of affected drivers: ptp_s390.c, ptp_vclock.c and ptp_mock.c.

Instead use a dummy callback if no better was specified by the driver.

Fixes: d94ba80ebbea ("ptp: Added a brand new class driver for ptp clocks.")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20250123-ptp-enable-v1-1-b015834d3a47@weissschuh.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/ptp/ptp_clock.c