]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: don't dump Tx and uninitialized NAPIs
authorJakub Kicinski <kuba@kernel.org>
Fri, 3 Jan 2025 18:32:07 +0000 (10:32 -0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 7 Jan 2025 12:07:31 +0000 (13:07 +0100)
commitfd48f071a3d6d51e737e953bb43fe69785cf59a9
treeea3a28d2235ee6a2cf4cca43d037eea8254eeaa3
parent4c1224501e9d6c5fd12d83752f1c1b444e0e3418
net: don't dump Tx and uninitialized NAPIs

We use NAPI ID as the key for continuing dumps. We also depend
on the NAPIs being sorted by ID within the driver list. Tx NAPIs
(which don't have an ID assigned) break this expectation, it's
not currently possible to dump them reliably. Since Tx NAPIs
are relatively rare, and can't be used in doit (GET or SET)
hide them from the dump API as well.

Fixes: 27f91aaf49b3 ("netdev-genl: Add netlink framework functions for napi")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250103183207.1216004-1-kuba@kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/core/netdev-genl.c