]> www.infradead.org Git - users/jedix/linux-maple.git/commit
hwmon: (ina2xx) Fix current value calculation
authorNicolin Chen <nicoleotsuka@gmail.com>
Wed, 14 Nov 2018 03:48:54 +0000 (19:48 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 08:28:48 +0000 (09:28 +0100)
commitfd2c1ba142277bfd6f3488e6105c9eb643246ddc
treec18b997009a9e2085f8fb4a61c4d51daab97458b
parent250dea0dfb12e2803d6de0105fae7177e4bd1b80
hwmon: (ina2xx) Fix current value calculation

[ Upstream commit 38cd989ee38c16388cde89db5b734f9d55b905f9 ]

The current register (04h) has a sign bit at MSB. The comments
for this calculation also mention that it's a signed register.

However, the regval is unsigned type so result of calculation
turns out to be an incorrect value when current is negative.

This patch simply fixes this by adding a casting to s16.

Fixes: 5d389b125186c ("hwmon: (ina2xx) Make calibration register value fixed")
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/ina2xx.c