]> www.infradead.org Git - users/jedix/linux-maple.git/commit
staging: gpib: Add lower bound check for secondary address
authorDave Penkler <dpenkler@gmail.com>
Sat, 7 Dec 2024 12:34:10 +0000 (13:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 20 Dec 2024 15:43:02 +0000 (16:43 +0100)
commitfd1885db8ecab1abc96dbb9df49b0d4b9eed1672
tree2dce5f2fc8118311a877f47671182ab73b2d8ede
parent4da38536e2190fb5bfabfcf5229f4d5398648295
staging: gpib: Add lower bound check for secondary address

Commit 9dde4559e939 ("staging: gpib: Add GPIB common core driver")
from Sep 18, 2024 (linux-next), leads to the following Smatch static
checker warning:

drivers/staging/gpib/common/gpib_os.c:541 dvrsp()
warn: no lower bound on 'sad' rl='s32min-30'

The value -1 was introduced in user land to signify No secondary address
to the driver so that a lower bound check could be added.

This patch adds that check.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-staging/4efd91f3-4259-4e95-a4e0-925853b98858@stanley.mountain/
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20241207123410.28759-1-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/common/gpib_os.c