]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: ath12k: remove msdu_end structure for WCN7850
authorLingbo Kong <quic_lingbok@quicinc.com>
Tue, 8 Oct 2024 09:30:39 +0000 (17:30 +0800)
committerJeff Johnson <quic_jjohnson@quicinc.com>
Tue, 22 Oct 2024 14:42:31 +0000 (07:42 -0700)
commitfd01ace1140476e97f1801a26e8e96a5626e3385
treebeb215233fe3a80b73d3f76f50a5e77eccb9db5f
parent477cabfdb776b571fab425813c074f30c02a5cf6
wifi: ath12k: remove msdu_end structure for WCN7850

Currently, when ath12k retrieves values from the structure
rx_msdu_end_wcn7850, the information obtained is incorrect. This is because
the definition of the rx_msdu_end_wcn7850 structure in ath12k is incorrect.
In fact, the rx_msdu_end structure used by WCN7850 is the same as the
rx_msdu_end structure of QCN9274.

Commit ed823fd113b7 ("wifi: ath12k: add msdu_end structure for WCN7850")
introduced this structure. The original issue trying to be fixed with that
commit is that the TID information retrieved from the rx_msdu_end structure
was incorrect, and it was thought that the structure wasn't correct, so a
supposedly correct structure was introduced. However it was subsequently
discovered that the TID information is only guaranteed to be valid in the
rx_msdu_start structure, so that commit added the logic to retrieve the TID
from the rx_msdu_start, but unfortunately kept the rx_msdu_end_wcn7850
structure.

To address this issue, revert the code related to the rx_msdu_end_wcn7850
structure, retaining the TID retrieval logic.

This patch does not affect QCN9274.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Fixes: ed823fd113b7 ("wifi: ath12k: add msdu_end structure for WCN7850")
Signed-off-by: Lingbo Kong <quic_lingbok@quicinc.com>
Link: https://patch.msgid.link/20241008093039.11076-1-quic_lingbok@quicinc.com
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
drivers/net/wireless/ath/ath12k/hal.c
drivers/net/wireless/ath/ath12k/rx_desc.h