]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iommu/arm-smmu-v3: Clean up more on probe failure
authorRobin Murphy <robin.murphy@arm.com>
Thu, 5 Dec 2024 16:33:57 +0000 (16:33 +0000)
committerWill Deacon <will@kernel.org>
Mon, 9 Dec 2024 22:46:53 +0000 (22:46 +0000)
commitfcbd621567420b3a2f21f49bbc056de8b273c625
tree1b3850c3109e0fcbb756151dabc0f0cd2b1e6f5b
parent97cb1fa0272646c2a033b05338bb8e0260879968
iommu/arm-smmu-v3: Clean up more on probe failure

kmemleak noticed that the iopf queue allocated deep down within
arm_smmu_init_structures() can be leaked by a subsequent error return
from arm_smmu_device_probe(). Furthermore, after arm_smmu_device_reset()
we will also leave the SMMU enabled with an empty Stream Table, silently
blocking all DMA. This proves rather annoying for debugging said probe
failure, so let's handle it a bit better by putting the SMMU back into
(more or less) the same state as if it hadn't probed at all.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Link: https://lore.kernel.org/r/5137901958471cf67f2fad5c2229f8a8f1ae901a.1733406914.git.robin.murphy@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c