]> www.infradead.org Git - users/hch/xfs.git/commit
btrfs: sysfs: fix direct super block member reads
authorQu Wenruo <wqu@suse.com>
Wed, 18 Dec 2024 06:30:56 +0000 (17:00 +1030)
committerDavid Sterba <dsterba@suse.com>
Mon, 23 Dec 2024 21:06:44 +0000 (22:06 +0100)
commitfca432e73db2bec0fdbfbf6d98d3ebcd5388a977
treec14e6802b1a4dc6a553a3bb19cbd187c209e9859
parentf2363e6fcc7938c5f0f6ac066fad0dd247598b51
btrfs: sysfs: fix direct super block member reads

The following sysfs entries are reading super block member directly,
which can have a different endian and cause wrong values:

- sys/fs/btrfs/<uuid>/nodesize
- sys/fs/btrfs/<uuid>/sectorsize
- sys/fs/btrfs/<uuid>/clone_alignment

Thankfully those values (nodesize and sectorsize) are always aligned
inside the btrfs_super_block, so it won't trigger unaligned read errors,
just endian problems.

Fix them by using the native cached members instead.

Fixes: df93589a1737 ("btrfs: export more from FS_INFO to sysfs")
CC: stable@vger.kernel.org
Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/sysfs.c