]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netfilter: nf_ct_helper: don't discard helper if it is actually the same
authorFlorian Westphal <fw@strlen.de>
Tue, 12 Feb 2013 05:59:53 +0000 (05:59 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 May 2013 20:53:55 +0000 (13:53 -0700)
commitfc27819bea8a7791c8a95e0db258389d3cb00887
tree50daf85820ca36a20af2af7958d94d3b5fb66015
parentcf75e569817b1311815cafe2ea39110e706479e0
netfilter: nf_ct_helper: don't discard helper if it is actually the same

commit 6e2f0aa8cf8892868bf2c19349cb5d7c407f690d upstream.

commit (32f5376 netfilter: nf_ct_helper: disable automatic helper
re-assignment of different type) broke transparent proxy scenarios.

For example, initial helper lookup might yield "ftp" (dport 21),
while re-lookup after REDIRECT yields "ftp-2121".

This causes the autoassign code to toss the ftp helper, even
though these are just different instances of the same helper.

Change the test to check for the helper function address instead
of the helper address, as suggested by Pablo.

Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@gnumonks.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_conntrack_helper.c