]> www.infradead.org Git - nvme.git/commit
ima: fix wrong zero-assignment during securityfs dentry remove
authorEnrico Bravi <enrico.bravi@polito.it>
Wed, 29 May 2024 18:14:34 +0000 (20:14 +0200)
committerMimi Zohar <zohar@linux.ibm.com>
Mon, 3 Jun 2024 20:37:22 +0000 (16:37 -0400)
commitfbf06cee60876d50f259d0689e3c03940750f0d4
tree597000d6614e1c6409ace04612af4e937d406f1f
parentc3f38fa61af77b49866b006939479069cd451173
ima: fix wrong zero-assignment during securityfs dentry remove

In case of error during ima_fs_init() all the dentry already created
are removed. {ascii, binary}_securityfs_measurement_lists are freed
calling for each array the remove_securityfs_measurement_lists(). This
function, at the end, assigns to zero the securityfs_measurement_list_count.
This causes during the second call of remove_securityfs_measurement_lists()
to leave the dentry of the array pending, not removing them correctly,
because the securityfs_measurement_list_count is already zero.

Move the securityfs_measurement_list_count = 0 after the two
remove_securityfs_measurement_lists() calls to correctly remove all the
dentry already allocated.

Fixes: 9fa8e7625008 ("ima: add crypto agility support for template-hash algorithm")
Signed-off-by: Enrico Bravi <enrico.bravi@polito.it>
Reviewed-by: Roberto Sassu <roberto.sassu@huawei.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
security/integrity/ima/ima_fs.c