]> www.infradead.org Git - users/hch/configfs.git/commit
ice: Flush FDB entries before reset
authorWojciech Drewek <wojciech.drewek@intel.com>
Fri, 27 Sep 2024 12:38:01 +0000 (14:38 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 8 Oct 2024 21:08:19 +0000 (14:08 -0700)
commitfbcb968a98ac0b71f5a2bda2751d7a32d201f90d
treeaf2eb8b90e968b60175ffd3c165074190e144823
parent8e60dbcbaaa177dacef55a61501790e201bf8c88
ice: Flush FDB entries before reset

Triggering the reset while in switchdev mode causes
errors[1]. Rules are already removed by this time
because switch content is flushed in case of the reset.
This means that rules were deleted from HW but SW
still thinks they exist so when we get
SWITCHDEV_FDB_DEL_TO_DEVICE notification we try to
delete not existing rule.

We can avoid these errors by clearing the rules
early in the reset flow before they are removed from HW.
Switchdev API will get notified that the rule was removed
so we won't get SWITCHDEV_FDB_DEL_TO_DEVICE notification.
Remove unnecessary ice_clear_sw_switch_recipes.

[1]
ice 0000:01:00.0: Failed to delete FDB forward rule, err: -2
ice 0000:01:00.0: Failed to delete FDB guard rule, err: -2

Fixes: 7c945a1a8e5f ("ice: Switchdev FDB events support")
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Signed-off-by: Wojciech Drewek <wojciech.drewek@intel.com>
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_eswitch_br.c
drivers/net/ethernet/intel/ice/ice_eswitch_br.h
drivers/net/ethernet/intel/ice/ice_main.c