]> www.infradead.org Git - users/hch/xfs.git/commit
net/smc: avoid overwriting when adjusting sock bufsizes
authorWen Gu <guwen@linux.alibaba.com>
Fri, 31 May 2024 08:54:17 +0000 (16:54 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jun 2024 08:42:57 +0000 (09:42 +0100)
commitfb0aa0781a5f457e3864da68af52c3b1f4f7fd8f
tree6c3472b6da62b25f61c3a4f47bed4bb4ec2f03ae
parent8b0f7410942cdc420c4557eda02bfcdf60ccec17
net/smc: avoid overwriting when adjusting sock bufsizes

When copying smc settings to clcsock, avoid setting clcsock's sk_sndbuf
to sysctl_tcp_wmem[1], since this may overwrite the value set by
tcp_sndbuf_expand() in TCP connection establishment.

And the other setting sk_{snd|rcv}buf to sysctl value in
smc_adjust_sock_bufsizes() can also be omitted since the initialization
of smc sock and clcsock has set sk_{snd|rcv}buf to smc.sysctl_{w|r}mem
or ipv4_sysctl_tcp_{w|r}mem[1].

Fixes: 30c3c4a4497c ("net/smc: Use correct buffer sizes when switching between TCP and SMC")
Link: https://lore.kernel.org/r/5eaf3858-e7fd-4db8-83e8-3d7a3e0e9ae2@linux.alibaba.com
Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Reviewed-by: Gerd Bayer <gbayer@linux.ibm.com>, too.
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/af_smc.c