]> www.infradead.org Git - users/dwmw2/linux.git/commit
md/raid5: Wait sync io to finish before changing group cnt
authorXiao Ni <xni@redhat.com>
Wed, 6 Nov 2024 09:51:24 +0000 (17:51 +0800)
committerSong Liu <song@kernel.org>
Thu, 7 Nov 2024 23:34:52 +0000 (15:34 -0800)
commitfa1944bbe6220eb929e2c02e5e8706b908565711
treee7daa76132a92f28a4a7aff146028b5ca969e737
parent4122fef16b172f7c1838fcf74340268c86ed96db
md/raid5: Wait sync io to finish before changing group cnt

One customer reports a bug: raid5 is hung when changing thread cnt
while resync is running. The stripes are all in conf->handle_list
and new threads can't handle them.

Commit b39f35ebe86d ("md: don't quiesce in mddev_suspend()") removes
pers->quiesce from mddev_suspend/resume. Before this patch, mddev_suspend
needs to wait for all ios including sync io to finish. Now it's used
to only wait normal io.

Fix this by calling raid5_quiesce from raid5_store_group_thread_cnt
directly to wait all sync requests to finish before changing the group
cnt.

Fixes: b39f35ebe86d ("md: don't quiesce in mddev_suspend()")
Cc: stable@vger.kernel.org
Signed-off-by: Xiao Ni <xni@redhat.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20241106095124.74577-1-xni@redhat.com
Signed-off-by: Song Liu <song@kernel.org>
drivers/md/raid5.c