]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/xe/guc: Fix uninitialised count in GuC load debug prints
authorJohn Harrison <John.C.Harrison@Intel.com>
Fri, 24 May 2024 20:26:03 +0000 (13:26 -0700)
committerJohn Harrison <John.C.Harrison@Intel.com>
Tue, 28 May 2024 21:53:09 +0000 (14:53 -0700)
commitfa171d49e49af89dfece89ade803a5d471d919a8
treebcd274f3c9713e43426b743bfb11a8f9acd092a6
parent8de6625dafd202da733188f632701e9109188035
drm/xe/guc: Fix uninitialised count in GuC load debug prints

The debug prints about how long the GuC load takes have a loop
counter. However that was neither initialised nor incremented! Plus,
counting loops is no longer meaningful given the wait function returns
early for any change in the status value. So fix it to only count
loops due to actual timeouts.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405250151.IbH0l8FG-lkp@intel.com/
Fixes: b0ac1b42dbdc ("drm/xe/guc: Port over the slow GuC loading support from i915")
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Oded Gabbay <ogabbay@kernel.org>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Fei Yang <fei.yang@intel.com>
Cc: intel-xe@lists.freedesktop.org
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240524202603.4011656-1-John.C.Harrison@Intel.com
drivers/gpu/drm/xe/xe_guc.c