]> www.infradead.org Git - users/jedix/linux-maple.git/commit
arm64: jump_label: use constraints "Si" instead of "i"
authorFangrui Song <maskray@google.com>
Tue, 6 Feb 2024 07:45:52 +0000 (23:45 -0800)
committerWill Deacon <will@kernel.org>
Fri, 9 Feb 2024 17:04:24 +0000 (17:04 +0000)
commitf9daab0ad01cf9d165dbbbf106ca4e61d06e7fe8
treeb0b82c3762f3ca74cad79a6d0bfaf584e8ec6a0d
parentc0b26c06ed008c0898829dda4c2783b8ec478350
arm64: jump_label: use constraints "Si" instead of "i"

The generic constraint "i" seems to be copied from x86 or arm (and with
a redundant generic operand modifier "c"). It works with -fno-PIE but
not with -fPIE/-fPIC in GCC's aarch64 port.

The machine constraint "S", which denotes a symbol or label reference
with a constant offset, supports PIC and has been available in GCC since
2012 and in Clang since 7.0. However, Clang before 19 does not support
"S" on a symbol with a constant offset [1] (e.g.
`static_key_false(&nf_hooks_needed[pf][hook])` in
include/linux/netfilter.h), so we use "i" as a fallback.

Suggested-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Fangrui Song <maskray@google.com>
Link: https://github.com/llvm/llvm-project/pull/80255
Acked-by: Mark Rutland <mark.rutland@arm.com>
Link: https://lore.kernel.org/r/20240206074552.541154-1-maskray@google.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/include/asm/jump_label.h