]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: mt76: mt7996: use hweight16 to get correct tx antenna
authorPeter Chiu <chui-hao.chiu@mediatek.com>
Fri, 16 Aug 2024 09:46:25 +0000 (17:46 +0800)
committerFelix Fietkau <nbd@nbd.name>
Thu, 5 Sep 2024 11:01:55 +0000 (13:01 +0200)
commitf98c3de92bb05dac4a4969df8a4595ed380b4604
tree9094eb56b8708ec62866e78c696e872e5bc5283a
parent723762a7a7e6fdb3cc6953f127a3fe9c5162beb7
wifi: mt76: mt7996: use hweight16 to get correct tx antenna

The chainmask is u16 so using hweight8 cannot get correct tx_ant.
Without this patch, the tx_ant of band 2 would be -1 and lead to the
following issue:
BUG: KASAN: stack-out-of-bounds in mt7996_mcu_add_sta+0x12e0/0x16e0 [mt7996e]

Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices")
Signed-off-by: Peter Chiu <chui-hao.chiu@mediatek.com>
Signed-off-by: Shayne Chen <shayne.chen@mediatek.com>
Link: https://patch.msgid.link/20240816094635.2391-1-shayne.chen@mediatek.com
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mcu.c