]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: iwlwifi: mvm: clean up ROC on failure
authorJohannes Berg <johannes.berg@intel.com>
Sun, 9 Feb 2025 12:34:47 +0000 (14:34 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 11 Feb 2025 11:41:46 +0000 (12:41 +0100)
commitf9751163bffd3fe60794929829f810968c6de73d
tree02915723804d64ba6e006385f1a6cccb99716cc9
parent3f8aa0b8a53df2247a84eaf3b3aa38b6ef86cb1c
wifi: iwlwifi: mvm: clean up ROC on failure

If the firmware fails to start the session protection, then we
do call iwl_mvm_roc_finished() here, but that won't do anything
at all because IWL_MVM_STATUS_ROC_P2P_RUNNING was never set.
Set IWL_MVM_STATUS_ROC_P2P_RUNNING in the failure/stop path.
If it started successfully before, it's already set, so that
doesn't matter, and if it didn't start it needs to be set to
clean up.

Not doing so will lead to a WARN_ON() later on a fresh remain-
on-channel, since the link is already active when activated as
it was never deactivated.

Fixes: 35c1bbd93c4e ("wifi: iwlwifi: mvm: remove IWL_MVM_STATUS_NEED_FLUSH_P2P")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250209143303.0fe36c291068.I67f5dac742170dd937f11e4d4f937f45f71b7cb4@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/time-event.c