]> www.infradead.org Git - users/hch/xfs.git/commit
net/sched: taprio: always validate TCA_TAPRIO_ATTR_PRIOMAP
authorEric Dumazet <edumazet@google.com>
Tue, 4 Jun 2024 18:15:11 +0000 (18:15 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 5 Jun 2024 22:54:51 +0000 (15:54 -0700)
commitf921a58ae20852d188f70842431ce6519c4fdc36
tree3c29a9ff0867da88895c4abcc490b0c2f6d600c9
parent229bedbf62b13af5aba6525ad10b62ad38d9ccb5
net/sched: taprio: always validate TCA_TAPRIO_ATTR_PRIOMAP

If one TCA_TAPRIO_ATTR_PRIOMAP attribute has been provided,
taprio_parse_mqprio_opt() must validate it, or userspace
can inject arbitrary data to the kernel, the second time
taprio_change() is called.

First call (with valid attributes) sets dev->num_tc
to a non zero value.

Second call (with arbitrary mqprio attributes)
returns early from taprio_parse_mqprio_opt()
and bad things can happen.

Fixes: a3d43c0d56f1 ("taprio: Add support adding an admin schedule")
Reported-by: Noam Rathaus <noamr@ssd-disclosure.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20240604181511.769870-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_taprio.c