]> www.infradead.org Git - nvme.git/commit
drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 12 Jun 2024 20:47:12 +0000 (23:47 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 24 Jun 2024 14:14:55 +0000 (17:14 +0300)
commitf8fa26f4e09230137a304a5275d2633a6de11c7d
tree317c6cf6981eb57d161fce0231b4b6e8d51a9f6b
parent7652126ce7070ddcd1b3f8791efcf7537a9ec01e
drm/i915: Nuke the TGL+ chroma plane tile row alignment stuff

I don't think the display hardware really has such chroma
plane tile row alignment requirements as outlined in
commit d156135e6a54 ("drm/i915/tgl: Make sure a semiplanar
UV plane is tile row size aligned")

Bspec had the same exact thing to say about earlier hardware
as well, but we never cared and things work just fine.

The one thing mentioned in that commit that is definitely
true however is the fence alignment issue. But we don't
deal with that on earlier hardware either. We do have code
to deal with that issue for the first color plane, but not
the chroma planes. So I think if we did want to check this
more extensively we should do it in the same places where
we already check the first color plane (namely
convert_plane_offset_to_xy() and intel_fb_bo_framebuffer_init()).

Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240612204712.31404-10-ville.syrjala@linux.intel.com
drivers/gpu/drm/i915/display/intel_fb.c
drivers/gpu/drm/i915/display/intel_fb.h
drivers/gpu/drm/i915/display/skl_universal_plane.c