]> www.infradead.org Git - users/jedix/linux-maple.git/commit
bnx2fc: Avoid calling bnx2fc_if_destroy with unnecessary locks
authorBhanu Prakash Gollapudi <bprakash@broadcom.com>
Tue, 30 Aug 2011 22:54:51 +0000 (15:54 -0700)
committerJoe Jin <joe.jin@oracle.com>
Thu, 17 May 2012 01:36:49 +0000 (09:36 +0800)
commitf8d5bbb0bcc5d00249de4c078c9799dbdbb79c96
tree95d9f7c9f903be9b7ad10bc61b5044843d28ba99
parent7a3a32aa146da2d4f1da01344f2f0d9ca9968491
bnx2fc: Avoid calling bnx2fc_if_destroy with unnecessary locks

It is not required to hold rtnl_lock and bnx2fc_dev_lock when calling
bnx2fc_if_destroy, as the locking is only required to serialize creation and
deletion of fcoe instances. More importantly, this unnecessary locking causes
deadlock as bnx2fc_if_destroy calls fc_remove_host holding rtnl_lock.

Signed-off-by: Bhanu Prakash Gollapudi <bprakash@broadcom.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
(cherry picked from commit 0cbf32e1681d870632a1772601cbaadd996dc978)

Signed-off-by: Joe Jin <joe.jin@oracle.com>
drivers/scsi/bnx2fc/bnx2fc_fcoe.c