]> www.infradead.org Git - users/hch/xfs.git/commit
freezer, sched: Report frozen tasks as 'D' instead of 'R'
authorChen Ridong <chenridong@huawei.com>
Tue, 17 Dec 2024 00:48:18 +0000 (00:48 +0000)
committerIngo Molnar <mingo@kernel.org>
Sun, 29 Dec 2024 09:14:20 +0000 (10:14 +0100)
commitf718faf3940e95d5d34af9041f279f598396ab7d
treee7de56efd375207fbb3b879748d37b4f37223809
parent78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8
freezer, sched: Report frozen tasks as 'D' instead of 'R'

Before commit:

  f5d39b020809 ("freezer,sched: Rewrite core freezer logic")

the frozen task stat was reported as 'D' in cgroup v1.

However, after rewriting the core freezer logic, the frozen task stat is
reported as 'R'. This is confusing, especially when a task with stat of
'S' is frozen.

This bug can be reproduced with these steps:

$ cd /sys/fs/cgroup/freezer/
$ mkdir test
$ sleep 1000 &
[1] 739         // task whose stat is 'S'
$ echo 739 > test/cgroup.procs
$ echo FROZEN > test/freezer.state
$ ps -aux | grep 739
root     739  0.1  0.0   8376  1812 pts/0    R    10:56   0:00 sleep 1000

As shown above, a task whose stat is 'S' was changed to 'R' when it was
frozen.

To solve this regression, simply maintain the same reported state as
before the rewrite.

[ mingo: Enhanced the changelog and comments ]

Fixes: f5d39b020809 ("freezer,sched: Rewrite core freezer logic")
Signed-off-by: Chen Ridong <chenridong@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-by: Michal Koutný <mkoutny@suse.com>
Link: https://lore.kernel.org/r/20241217004818.3200515-1-chenridong@huaweicloud.com
include/linux/sched.h