]> www.infradead.org Git - users/dwmw2/linux.git/commit
bpf: Do not WARN in bpf_warn_invalid_xdp_action()
authorPaolo Abeni <pabeni@redhat.com>
Tue, 30 Nov 2021 10:08:06 +0000 (11:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jan 2022 08:04:25 +0000 (09:04 +0100)
commitf6d5eb174ee9b9ca4911b98f243f149fbfd19a43
tree0e6a81ce4f12d5b0c8ea61c34eb6f1e2bfe0c7bf
parent4cca06db20796f60ad83943b80664ef0d652dcac
bpf: Do not WARN in bpf_warn_invalid_xdp_action()

[ Upstream commit 2cbad989033bff0256675c38f96f5faab852af4b ]

The WARN_ONCE() in bpf_warn_invalid_xdp_action() can be triggered by
any bugged program, and even attaching a correct program to a NIC
not supporting the given action.

The resulting splat, beyond polluting the logs, fouls automated tools:
e.g. a syzkaller reproducers using an XDP program returning an
unsupported action will never pass validation.

Replace the WARN_ONCE with a less intrusive pr_warn_once().

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://lore.kernel.org/bpf/016ceec56e4817ebb2a9e35ce794d5c917df572c.1638189075.git.pabeni@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/filter.c