]> www.infradead.org Git - users/dwmw2/qemu.git/commit
tests/functional/test_x86_64_hotplug_cpu: Fix race condition during unplug
authorThomas Huth <thuth@redhat.com>
Tue, 7 Jan 2025 11:52:45 +0000 (12:52 +0100)
committerThomas Huth <thuth@redhat.com>
Tue, 7 Jan 2025 14:02:46 +0000 (15:02 +0100)
commitf69705f300f487936919359354925395105ec018
treea76a679416e4e0a3e49b21e6e555f0f6b263dd0a
parent5cd37fe6dd278302ed6ceb86727526a38f410314
tests/functional/test_x86_64_hotplug_cpu: Fix race condition during unplug

When unplugging the CPU, the test tries to check for a successful
unplug by changing to the /sys/devices/system/cpu/cpu1 directory
to see whether that fails. However, the "cd" could be faster than
the unplug operation in the kernel, so there is a race condition
and the test sometimes fails here.
Fix it by trying to change the directory in a loop until the the
CPU has really been unplugged.
While we're at it, also add a "cd .." before unplugging to make
the console output a little bit less confusing (since the path
is echoed in the shell prompt).

Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20250107115245.52755-1-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
tests/functional/test_x86_64_hotplug_cpu.py