]> www.infradead.org Git - users/jedix/linux-maple.git/commit
gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines
authorVitalii Mordan <mordan@ispras.ru>
Fri, 14 Feb 2025 15:46:32 +0000 (18:46 +0300)
committerRobert Foss <rfoss@kernel.org>
Mon, 17 Feb 2025 13:09:48 +0000 (14:09 +0100)
commitf65727be3fa5f252c8d982d15023aab8255ded19
treec75fb92490639c960e772dff45b2193fc111b746
parentb24dcc183583fc360ae0f0899e286a68f46abbd0
gpu: cdns-mhdp8546: fix call balance of mhdp->clk handling routines

If the clock mhdp->clk was not enabled in cdns_mhdp_probe(), it should not
be disabled in any path.

The return value of clk_prepare_enable() is not checked. If mhdp->clk was
not enabled, it may be disabled in the error path of cdns_mhdp_probe()
(e.g., if cdns_mhdp_load_firmware() fails) or in cdns_mhdp_remove() after
a successful cdns_mhdp_probe() call.

Use the devm_clk_get_enabled() helper function to ensure proper call
balance for mhdp->clk.

Found by Linux Verification Center (linuxtesting.org) with Klever.

Fixes: fb43aa0acdfd ("drm: bridge: Add support for Cadence MHDP8546 DPI/DP bridge")
Signed-off-by: Vitalii Mordan <mordan@ispras.ru>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250214154632.1907425-1-mordan@ispras.ru
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c