]> www.infradead.org Git - users/jedix/linux-maple.git/commit
libperf: Don't remove -g when EXTRA_CFLAGS are used
authorJames Clark <james.clark@linaro.org>
Wed, 19 Mar 2025 11:40:09 +0000 (11:40 +0000)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 20 Mar 2025 00:00:39 +0000 (17:00 -0700)
commitf5b07010c13c77541e8ade167d05bef3b8a63739
tree0d793ee57db4a5dcc36a5406d40d5d10b422e178
parent431db90a7303cb394c5a881b4479946f64052727
libperf: Don't remove -g when EXTRA_CFLAGS are used

When using EXTRA_CFLAGS, for example "EXTRA_CFLAGS=-DREFCNT_CHECKING=1",
this construct stops setting -g which you'd expect would not be affected
by adding extra flags. Additionally, EXTRA_CFLAGS should be the last
thing to be appended so that it can be used to undo any defaults. And no
condition is required, just += appends to any existing CFLAGS and also
appends or doesn't append EXTRA_CFLAGS if they are or aren't set.

It's not clear why DEBUG=1 is required for -g in Perf when in libperf
it's always on, but I don't think we need to change that behavior now
because someone may be depending on it.

Signed-off-by: James Clark <james.clark@linaro.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250319114009.417865-1-james.clark@linaro.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/lib/perf/Makefile