]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: light: rpr0521: Use generic iio_pollfunc_store_time()
authorVasileios Amoiridis <vassilisamir@gmail.com>
Sun, 22 Sep 2024 16:20:40 +0000 (18:20 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 15 Oct 2024 17:59:51 +0000 (18:59 +0100)
commitf548c11a85ff08e3c6ac7fdf995cb98bf95c9acf
tree1ae49c07cbc8f03005f864016a7aef78d5fa658f
parenteeebe3937cfc7af3b4686a69432f6ae153470a9d
iio: light: rpr0521: Use generic iio_pollfunc_store_time()

The custom rpr0521_trigger_consumer_store_time() is registered as trigger
handler in the devm_iio_triggered_buffer_setup() function. This function
is called from the calling of the iio_trigger_poll() used in the
sysfs/hrt triggers and it is not used anywhere else in this driver.

The irq handler of the driver is the rpr0521_drdy_irq_handler() which
saves the timestamp and then wakes the irq thread. The irq thread is
the rpr0521_drdy_irq_thread() function which checks if the irq came
from the sensor and wakes up the trigger threaded handler through
iio_trigger_poll_nested() or returns IRQ_NONE in case the irq didn't
come from this sensor.

This means that in the current driver, you can't reach the
rpr0521_trigger_consumer_store_time() when the device's irq is
triggered. This means that the extra check of iio_trigger_using_own()
is redundant since it will always be false so the general
iio_pollfunc_store_time() can be used.

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
Link: https://patch.msgid.link/20240922162041.525896-2-vassilisamir@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/rpr0521.c