]> www.infradead.org Git - users/jedix/linux-maple.git/commit
spi: cs42l43: Make handling missing spk-id GPIOs explicit
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 1 May 2025 15:02:00 +0000 (17:02 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 5 May 2025 10:31:28 +0000 (19:31 +0900)
commitf4ea37a485e97234af9550b63c52394d029037ee
treeee2479078d6a88742ab6bfff0c0759c2a6fdf579
parent075812e45e9ef1b882aa66b9d122d8b8739aae59
spi: cs42l43: Make handling missing spk-id GPIOs explicit

gpiod_get_array_optional() for spk-id GPIOs can return NULL, if they are
missing, so do not pass the value to PTR_ERR but instead explicitly
treat NULL as acceptable condition.  The old code was correct, but
misleading because PTR_ERR usually is used on errors.

Reported by Smatch:
  drivers/spi/spi-cs42l43.c:241 cs42l43_get_speaker_id_gpios() warn: passing zero to 'PTR_ERR'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20250501-n-smatch-fixes-v2-2-d2ad9c1f2e67@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cs42l43.c