]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mpls: Reduce skb re-allocations due to skb_cow()
authorChristoph Paasch <cpaasch@apple.com>
Thu, 15 Aug 2024 16:12:01 +0000 (09:12 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 17 Aug 2024 00:53:49 +0000 (17:53 -0700)
commitf4ae8420f6ebdabf97e0c4f5f99412768687985f
tree83c016cf129805a11a6e0024fd99f631604fed5c
parent1c66df862561a11a8ea9b4c97ecfe91983c3bda7
mpls: Reduce skb re-allocations due to skb_cow()

mpls_xmit() needs to prepend the MPLS-labels to the packet. That implies
one needs to make sure there is enough space for it in the headers.

Calling skb_cow() implies however that one wants to change even the
playload part of the packet (which is not true for MPLS). Thus, call
skb_cow_head() instead, which is what other tunnelling protocols do.

Running a server with this comm it entirely removed the calls to
pskb_expand_head() from the callstack in mpls_xmit() thus having
significant CPU-reduction, especially at peak times.

Cc: Roopa Prabhu <roopa@nvidia.com>
Reported-by: Craig Taylor <cmtaylor@apple.com>
Signed-off-by: Christoph Paasch <cpaasch@apple.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240815161201.22021-1-cpaasch@apple.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mpls/mpls_iptunnel.c