]> www.infradead.org Git - mtd-utils.git/commit
Remove unused and broken mtd_write_img function from libmtd
authorDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Thu, 25 Aug 2016 11:41:50 +0000 (13:41 +0200)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Thu, 17 Nov 2016 10:36:55 +0000 (11:36 +0100)
commitf45bc6e3c99b62d04d50f210ed8d4f8d02b15357
tree4251a99371b756dc55ba2e0c66a7c2ee139b4960
parent5841f15bf5d9cba2bdcc6526000538fedeee46e3
Remove unused and broken mtd_write_img function from libmtd

The function _tries_ to support short reads but doesn't adjust the
pointer into the buffer. If a short read happens, we scrambles the
flash contents. Interrupted reads aren't handled. Short or
interrupted writes aren't handled at all. Either a write succeeds
writing the entire buffer or the function gives up.

During an attempt at fixing it, it was discovered, that no mtd-utils
program uses this function. Furthermore, its highly specific nature
makes it more of a "feature looking for use case".

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Signed-off-by: Richard Weinberger <richard@nod.at>
include/libmtd.h
lib/libmtd.c