]> www.infradead.org Git - nvme.git/commit
scsi: Fix sshdr use in scsi_test_unit_ready
authorMike Christie <michael.christie@oracle.com>
Wed, 4 Oct 2023 21:00:10 +0000 (16:00 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 13 Oct 2023 20:36:20 +0000 (16:36 -0400)
commitf43158eefd655d34e38b0cc35b959149ddf02485
tree002577196114ab835ca39ba17db401bf6fdea61a
parentadd2c24d32a38402dfec3c1465f332ab8a769890
scsi: Fix sshdr use in scsi_test_unit_ready

If scsi_execute_cmd returns < 0, it doesn't initialize the sshdr, so we
shouldn't access the sshdr. If it returns 0, then the cmd executed
successfully, so there is no need to check the sshdr. This has us access
the sshdr when we get a return value > 0.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Link: https://lore.kernel.org/r/20231004210013.5601-10-michael.christie@oracle.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_lib.c