]> www.infradead.org Git - linux.git/commit
ASoC: codecs: sdw-mockup: simplify set_stream
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 24 Mar 2023 01:43:57 +0000 (09:43 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 29 Mar 2023 14:03:00 +0000 (15:03 +0100)
commitf3def177876450df07fab6f28ad24a70397dc94d
tree5a29424b3dfab16428efb5639a019a3c738dc30e
parent892855d57c47c32f475e9efa36c1a3452cc19918
ASoC: codecs: sdw-mockup: simplify set_stream

Using a dynamic allocation to store a single pointer is not very
efficient/useful.

Worse, the memory is released in the SoundWire stream.c file, but
still accessed in the DAI shutdown, leading to kmemleak reports.

And last the API requires the previous stream information to be
cleared when the argument is NULL.

Simplify the code to address all 3 problems.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230324014408.1677505-3-yung-chuan.liao@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/sdw-mockup.c