]> www.infradead.org Git - linux.git/commit
NFSD: use read_seqbegin() rather than read_seqbegin_or_lock()
authorOleg Nesterov <oleg@redhat.com>
Thu, 26 Oct 2023 14:50:18 +0000 (16:50 +0200)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 7 Jan 2024 22:54:24 +0000 (17:54 -0500)
commitf3734cc4073f68ac3566293acc6d62971c47ad5a
tree8aaf609d1b7373badab1d8748297bda709cf18c2
parent74fd48739d0488e39ae18b0168720f449a06690c
NFSD: use read_seqbegin() rather than read_seqbegin_or_lock()

The usage of read_seqbegin_or_lock() in nfsd_copy_write_verifier()
is wrong. "seq" is always even and thus "or_lock" has no effect,
this code can never take ->writeverf_lock for writing.

I guess this is fine, nfsd_copy_write_verifier() just copies 8 bytes
and nfsd_reset_write_verifier() is supposed to be very rare operation
so we do not need the adaptive locking in this case.

Yet the code looks wrong and sub-optimal, it can use read_seqbegin()
without changing the behaviour.

[ cel: Note also that it eliminates this Sparse warning:

fs/nfsd/nfssvc.c:360:6: warning: context imbalance in 'nfsd_copy_write_verifier' -
different lock contexts for basic block

]

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfssvc.c