]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xenbus: don't bail early from xenbus_dev_request_and_reply()
authorJan Beulich <JBeulich@suse.com>
Thu, 7 Jul 2016 07:32:04 +0000 (01:32 -0600)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Wed, 13 Jul 2016 17:27:53 +0000 (13:27 -0400)
commitf36f3d4513f56fc878003dcaf65377f30c25fc81
tree5c2bd768ae6b1c87d7f06d305cf8efabba399cf0
parent9b558ec261f9f84db033fffdeb871af9451b901e
xenbus: don't bail early from xenbus_dev_request_and_reply()

xenbus_dev_request_and_reply() needs to track whether a transaction is
open.  For XS_TRANSACTION_START messages it calls transaction_start()
and for XS_TRANSACTION_END messages it calls transaction_end().

If sending an XS_TRANSACTION_START message fails or responds with an
an error, the transaction is not open and transaction_end() must be
called.

If sending an XS_TRANSACTION_END message fails, the transaction is
still open, but if an error response is returned the transaction is
closed.

Commit 027bd7e89906 ("xen/xenbus: Avoid synchronous wait on XenBus
stalling shutdown/restart") introduced a regression where failed
XS_TRANSACTION_START messages were leaving the transaction open.  This
can cause problems with suspend (and migration) as all transactions
must be closed before suspending.

It appears that the problematic change was added accidentally, so just
remove it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
(cherry picked from commit 7469be95a487319514adce2304ad2af3553d2fc9)
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
OraBug: 23585393
drivers/xen/xenbus/xenbus_xs.c