]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netmem: prevent TX of unreadable skbs
authorMina Almasry <almasrymina@google.com>
Thu, 6 Mar 2025 21:55:20 +0000 (21:55 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Mar 2025 03:32:25 +0000 (19:32 -0800)
commitf3600c867c99a2cc8038680ecf211089c50e7971
treee65358d95b4cd39348c848a0ed2e8afd3f8e65ed
parent8ef0f2c01898559eede2c51cb89dbf07acdc6c7a
netmem: prevent TX of unreadable skbs

Currently on stable trees we have support for netmem/devmem RX but not
TX. It is not safe to forward/redirect an RX unreadable netmem packet
into the device's TX path, as the device may call dma-mapping APIs on
dma addrs that should not be passed to it.

Fix this by preventing the xmit of unreadable skbs.

Tested by configuring tc redirect:

sudo tc qdisc add dev eth1 ingress
sudo tc filter add dev eth1 ingress protocol ip prio 1 flower ip_proto \
tcp src_ip 192.168.1.12 action mirred egress redirect dev eth1

Before, I see unreadable skbs in the driver's TX path passed to dma
mapping APIs.

After, I don't see unreadable skbs in the driver's TX path passed to dma
mapping APIs.

Fixes: 65249feb6b3d ("net: add support for skbs with unreadable frags")
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Cc: stable@vger.kernel.org
Signed-off-by: Mina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250306215520.1415465-1-almasrymina@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/dev.c