]> www.infradead.org Git - users/jedix/linux-maple.git/commit
Bluetooth: hidp: buffer overflow in hidp_process_report
authorMark Salyzyn <salyzyn@android.com>
Tue, 31 Jul 2018 22:02:13 +0000 (15:02 -0700)
committerBrian Maly <brian.maly@oracle.com>
Wed, 2 Jan 2019 17:55:43 +0000 (12:55 -0500)
commitf34f79808e45e18a09dddc16c112ca0aa8a88f94
treeef074592287ce1d398fdaf1c74b1e014309e9af5
parentfb7c4ce95e66b6dbbaab6bdac01b0d20e51b3b10
Bluetooth: hidp: buffer overflow in hidp_process_report

commit 7992c18810e568b95c869b227137a2215702a805 upstream.

CVE-2018-9363

The buffer length is unsigned at all layers, but gets cast to int and
checked in hidp_process_report and can lead to a buffer overflow.
Switch len parameter to unsigned int to resolve issue.

This affects 3.18 and newer kernels.

Signed-off-by: Mark Salyzyn <salyzyn@android.com>
Fixes: a4b1b5877b514b276f0f31efe02388a9c2836728 ("HID: Bluetooth: hidp: make sure input buffers are big enough")
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: linux-bluetooth@vger.kernel.org
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: security@kernel.org
Cc: kernel-team@android.com
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 17c1e0b1f6a161cc4f533d4869ff574273dbfe8d)

Orabug: 29121215
CVE: CVE-2018-9363

Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
Reviewed-by: John Haxby <john.haxby@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
net/bluetooth/hidp/core.c