]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: wacom: fix crash in wacom_aes_battery_handler()
authorThomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
Mon, 19 May 2025 08:54:46 +0000 (10:54 +0200)
committerJiri Kosina <jkosina@suse.com>
Tue, 10 Jun 2025 22:27:10 +0000 (00:27 +0200)
commitf3054152c12e2eed1e72704aff47b0ea58229584
tree5d176e816ff48c871a83250da5ec957ff94a79d9
parent5cdb49a680b45f467e9d915c0e74756bc0c67c57
HID: wacom: fix crash in wacom_aes_battery_handler()

Commit fd2a9b29dc9c ("HID: wacom: Remove AES power_supply after extended
inactivity") introduced wacom_aes_battery_handler() which is scheduled
as a delayed work (aes_battery_work).

In wacom_remove(), aes_battery_work is not canceled. Consequently, if
the device is removed while aes_battery_work is still pending, then hard
crashes or "Oops: general protection fault..." are experienced when
wacom_aes_battery_handler() is finally called. E.g., this happens with
built-in USB devices after resume from hibernate when aes_battery_work
was still pending at the time of hibernation.

So, take care to cancel aes_battery_work in wacom_remove().

Fixes: fd2a9b29dc9c ("HID: wacom: Remove AES power_supply after extended inactivity")
Signed-off-by: Thomas Zeitlhofer <thomas.zeitlhofer+lkml@ze-it.at>
Acked-by: Ping Cheng <ping.cheng@wacom.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_sys.c