]> www.infradead.org Git - users/willy/xarray.git/commit
scsi: message: fusion: struct _CONFIG_PAGE_IOC_4: Replace 1-element array with flexib...
authorKees Cook <kees@kernel.org>
Thu, 11 Jul 2024 17:28:20 +0000 (10:28 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 3 Aug 2024 01:32:52 +0000 (21:32 -0400)
commitf296cc1d7f5aeccd0d87ec167e0aea05acb8a022
treeb48d054bdcc812bebaa46616a118cfcad035f275
parent70631322dbab5b48f49f142dd9aef768c0fb077c
scsi: message: fusion: struct _CONFIG_PAGE_IOC_4: Replace 1-element array with flexible array

Replace the deprecated[1] use of a 1-element array in struct
_CONFIG_PAGE_IOC_4 with a modern flexible array.

Additionally add __counted_by annotation since SEP is only ever accessed
after updating ACtiveSEP:

lsi/mpi_cnfg.h:    IOC_4_SEP                   SEP[] __counted_by(ActiveSEP);  /* 08h */
mptsas.c:        ii = IOCPage4Ptr->ActiveSEP++;
mptsas.c:        IOCPage4Ptr->SEP[ii].SEPTargetID = id;
mptsas.c:        IOCPage4Ptr->SEP[ii].SEPBus = channel;

No binary differences are present after this conversion.

Link: https://github.com/KSPP/linux/issues/79
Signed-off-by: Kees Cook <kees@kernel.org>
Link: https://lore.kernel.org/r/20240711172821.123936-6-kees@kernel.org
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/lsi/mpi_cnfg.h