]> www.infradead.org Git - users/sagi/libnvme.git/commit
ioctl: Rearrange members in nvme_directive_recv_args
authorDaniel Wagner <dwagner@suse.de>
Thu, 13 Jan 2022 14:42:22 +0000 (15:42 +0100)
committerDaniel Wagner <dwagner@suse.de>
Thu, 13 Jan 2022 17:44:03 +0000 (18:44 +0100)
commitf283430be9602ff5cde3eb6f5b4f0b94dfb09401
tree1e0c1c1affe292ca8388e073268090b662dcb003
parentf824455baae24ea0dfa7dd8e057884ef9718b716
ioctl: Rearrange members in nvme_directive_recv_args

Avoid any holes in the struct by rearranging the members. Also add the
attribute packed to struct definition to reduce ABI breakage.

struct nvme_directive_recv_args {
        int                        args_size;            /*     0     4 */
        int                        fd;                   /*     4     4 */
        __u32 *                    result;               /*     8     8 */
        __u32                      timeout;              /*    16     4 */
        __u32                      nsid;                 /*    20     4 */
        enum nvme_directive_receive_doper doper;         /*    24     4 */
        enum nvme_directive_dtype  dtype;                /*    28     4 */
        __u32                      cdw12;                /*    32     4 */
        __u32                      data_len;             /*    36     4 */
        void *                     data;                 /*    40     8 */
        __u16                      dspec;                /*    48     2 */

        /* size: 56, cachelines: 1, members: 11 */
        /* padding: 6 */
        /* last cacheline: 56 bytes */
} __attribute__((__aligned__(8)));

Signed-off-by: Daniel Wagner <dwagner@suse.de>
src/nvme/ioctl.h