]> www.infradead.org Git - users/dwmw2/linux.git/commit
ASoC: cs35l56: Avoid static analysis warning of uninitialised variable
authorSimon Trimmer <simont@opensource.cirrus.com>
Mon, 22 Apr 2024 10:32:11 +0000 (11:32 +0100)
committerMark Brown <broonie@kernel.org>
Tue, 23 Apr 2024 01:34:08 +0000 (10:34 +0900)
commitf2602fba4723e408380eb9a56e921d36a1ae21f8
tree729defb1f9aff71317834f37c22830a0f0a5edad
parent32ac501957e5f68fe0e4bf88fb4db75cfb8f6566
ASoC: cs35l56: Avoid static analysis warning of uninitialised variable

Static checkers complain that the silicon_uid variable passed by
pointer to cs35l56_read_silicon_uid() could later be used
uninitialised when calling cs_amp_get_efi_calibration_data().

cs35l56_read_silicon_uid() must have succeeded to call
cs_amp_get_efi_calibration_data() and that would have populated the
variable.

However, initialise the value so we are not haunted by it forevermore.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
Fixes: e1830f66f6c6 ("ASoC: cs35l56: Add helper functions for amp calibration")
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20240422103211.236063-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56-shared.c