]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ASoC: SOF: imx-common: set sdev->pdata->hw_pdata after common is alloc'd
authorLaurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Tue, 11 Feb 2025 22:50:18 +0000 (17:50 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 12 Feb 2025 13:46:00 +0000 (13:46 +0000)
commitf22ba3561daa792dd138ed543e0bf48efe0b999c
tree9fc60aa6a06c76fe4ce476d020f633c5b04a671f
parent21aa330fec31bb530a4ef6c9555fb157d0711112
ASoC: SOF: imx-common: set sdev->pdata->hw_pdata after common is alloc'd

'imx_unregister_action' uses 'sdev->pdata->hw_pdata' to fetch the pointer
to the common data structure. As such, if 'sdev->pdata->hw_pdata' is not
set before adding 'imx_unregister_action' to the devres list, we risk
derefrencing a NULL pointer if any of the calls between
'devm_add_action_or_reset' and 'sdev->pdata->hw_pdata = common' fails.

Set 'sdev->pdata->hw_pdata' to point to 'common' as soon as 'common' is
allocated.

Fixes: 651e0ed391b1 (" ASoC: SOF: imx: introduce more common structures and functions")
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://patch.msgid.link/20250211225018.2642-1-laurentiumihalcea111@gmail.com
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/imx/imx-common.c