]> www.infradead.org Git - users/dwmw2/linux.git/commit
omap2fb: Fix stack memory disclosure
authorVlad Tsyrklevich <vlad@tsyrklevich.net>
Fri, 11 Jan 2019 13:34:38 +0000 (14:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 20:09:55 +0000 (21:09 +0100)
commitf134f703dd8a1a93b8f59e7610062dfab90a771c
tree803c9bfdb3c7eb898c9b6fb4a1ebf426a858a26d
parent43805c8fde671c7190b7735c8325cf8cde6df54d
omap2fb: Fix stack memory disclosure

commit a01421e4484327fe44f8e126793ed5a48a221e24 upstream.

Using [1] for static analysis I found that the OMAPFB_QUERY_PLANE,
OMAPFB_GET_COLOR_KEY, OMAPFB_GET_DISPLAY_INFO, and OMAPFB_GET_VRAM_INFO
cases could all leak uninitialized stack memory--either due to
uninitialized padding or 'reserved' fields.

Fix them by clearing the shared union used to store copied out data.

[1] https://github.com/vlad902/kernel-uninitialized-memory-checker

Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Reviewed-by: Kees Cook <keescook@chromium.org>
Fixes: b39a982ddecf ("OMAP: DSS2: omapfb driver")
Cc: security@kernel.org
[b.zolnierkie: prefix patch subject with "omap2fb: "]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/video/fbdev/omap2/omapfb/omapfb-ioctl.c