]> www.infradead.org Git - users/jedix/linux-maple.git/commit
cifs: lock chan_lock outside match_session
authorShyam Prasad N <sprasad@microsoft.com>
Mon, 20 Feb 2023 13:02:11 +0000 (13:02 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Mar 2023 10:49:20 +0000 (12:49 +0200)
commitf11f6ea883de3eef3fe0a33c7df40de16e3115a5
tree9a9738fd2efcb9a0f858e840e02a151978dc1dd9
parent4c8fc3fe28e47e2a495444347375f7354c24b018
cifs: lock chan_lock outside match_session

commit 2f4e429c846972c8405951a9ff7a82aceeca7461 upstream.

Coverity had rightly indicated a possible deadlock
due to chan_lock being done inside match_session.
All callers of match_* functions should pick up the
necessary locks and call them.

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Cc: stable@vger.kernel.org
Fixes: 724244cdb382 ("cifs: protect session channel fields with chan_lock")
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/connect.c