]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: dsa: b53: do not program vlans when vlan filtering is off
authorJonas Gorski <jonas.gorski@gmail.com>
Tue, 29 Apr 2025 20:17:07 +0000 (22:17 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 8 May 2025 02:30:35 +0000 (19:30 -0700)
commitf089652b6b16452535dcc5cbaa6e2bb05acd3f93
treee299fe0faa5c9f6d2478136b109ca441ff49d07a
parent45e9d59d39503bb3e6ab4d258caea4ba6496e2dc
net: dsa: b53: do not program vlans when vlan filtering is off

Documentation/networking/switchdev.rst says:

- with VLAN filtering turned off: the bridge is strictly VLAN unaware and its
  data path will process all Ethernet frames as if they are VLAN-untagged.
  The bridge VLAN database can still be modified, but the modifications should
  have no effect while VLAN filtering is turned off.

This breaks if we immediately apply the VLAN configuration, so skip
writing it when vlan_filtering is off.

Fixes: 0ee2af4ebbe3 ("net: dsa: set configure_vlan_while_not_filtering to true by default")
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250429201710.330937-9-jonas.gorski@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/b53/b53_common.c