]> www.infradead.org Git - users/dwmw2/linux.git/commit
NFS: Fix READ_PLUS when server doesn't support OP_READ_PLUS
authorAnna Schumaker <Anna.Schumaker@Netapp.com>
Thu, 25 Apr 2024 20:24:29 +0000 (16:24 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 20 May 2024 15:37:15 +0000 (11:37 -0400)
commitf06d1b10cb016d5aaecdb1804fefca025387bd10
treec419fa88261324df9acd7b7ceccbdbc2371912b2
parent0dc9f430027b8bd9073fdafdfcdeb1a073ab5594
NFS: Fix READ_PLUS when server doesn't support OP_READ_PLUS

Olga showed me a case where the client was sending multiple READ_PLUS
calls to the server in parallel, and the server replied
NFS4ERR_OPNOTSUPP to each. The client would fall back to READ for the
first reply, but fail to retry the other calls.

I fix this by removing the test for NFS_CAP_READ_PLUS in
nfs4_read_plus_not_supported(). This allows us to reschedule any
READ_PLUS call that has a NFS4ERR_OPNOTSUPP return value, even after the
capability has been cleared.

Reported-by: Olga Kornievskaia <kolga@netapp.com>
Fixes: c567552612ec ("NFS: Add READ_PLUS data segment support")
Cc: stable@vger.kernel.org # v5.10+
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs4proc.c