]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown
authorDouglas Anderson <dianders@chromium.org>
Fri, 21 Jun 2024 20:44:29 +0000 (13:44 -0700)
committerDouglas Anderson <dianders@chromium.org>
Mon, 22 Jul 2024 16:00:58 +0000 (09:00 -0700)
commitf00bfaca704ca1a2c4e31501a0a7d4ee434e73a7
tree7023adb2c1d19e4a43da2f8efce834eee5386688
parent1f7ce4316d8c8ca8fdf5e477fee91012420b1fa3
drm/panel: Avoid warnings w/ panel-simple/panel-edp at shutdown

At shutdown if you've got a _properly_ coded DRM modeset driver then
you'll get these two warnings at shutdown time:

  Skipping disable of already disabled panel
  Skipping unprepare of already unprepared panel

These warnings are ugly and sound concerning, but they're actually a
sign of a properly working system. That's not great.

We're not ready to get rid of the calls to drm_panel_disable() and
drm_panel_unprepare() because we're not 100% convinced that all DRM
modeset drivers are properly calling drm_atomic_helper_shutdown() or
drm_helper_force_disable_all() at the right times. However, having the
warning show up for correctly working systems is bad.

As a bit of a workaround, add some "if" tests to try to avoid the
warning on correctly working systems. Also add some comments and
update the TODO items in the hopes that future developers won't be too
confused by what's going on here.

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621134427.1.Ieb287c2c3ee3f6d3b0d5f49b29f746b93621749c@changeid
Documentation/gpu/todo.rst
drivers/gpu/drm/drm_panel.c
drivers/gpu/drm/panel/panel-edp.c
drivers/gpu/drm/panel/panel-simple.c