]> www.infradead.org Git - users/dwmw2/linux.git/commit
usbnet: ipheth: break up NCM header size computation
authorFoster Snowhill <forst@pen.gy>
Sat, 25 Jan 2025 23:54:07 +0000 (00:54 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 28 Jan 2025 11:16:32 +0000 (12:16 +0100)
commitefcbc678a14be268040ffc1fa33c98faf2d55141
tree7e788e3524bd6d198793eaf9c896d292a89605fb
parent2a9a196429e98fcc64078366c2679bc40aba5466
usbnet: ipheth: break up NCM header size computation

Originally, the total NCM header size was computed as the sum of two
vaguely labelled constants. While accurate, it wasn't particularly clear
where they were coming from.

Use sizes of existing NCM structs where available. Define the total
NDP16 size based on the maximum amount of DPEs that can fit into the
iOS-specific fixed-size header.

This change does not fix any particular issue. Rather, it introduces
intermediate constants that will simplify subsequent commits.
It should also make it clearer for the reader where the constant values
come from.

Cc: stable@vger.kernel.org # 6.5.x
Signed-off-by: Foster Snowhill <forst@pen.gy>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/usb/ipheth.c