]> www.infradead.org Git - users/jedix/linux-maple.git/commit
iio: adc: ad7124: fix division by zero in ad7124_set_channel_odr()
authorZicheng Qu <quzicheng@huawei.com>
Tue, 22 Oct 2024 13:43:30 +0000 (13:43 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 24 Oct 2024 17:30:47 +0000 (18:30 +0100)
commitefa353ae1b0541981bc96dbf2e586387d0392baa
tree13ef6f459de94a966d1418624aa271f3bb17e4ce
parent6bd301819f8f69331a55ae2336c8b111fc933f3d
iio: adc: ad7124: fix division by zero in ad7124_set_channel_odr()

In the ad7124_write_raw() function, parameter val can potentially
be zero. This may lead to a division by zero when DIV_ROUND_CLOSEST()
is called within ad7124_set_channel_odr(). The ad7124_write_raw()
function is invoked through the sequence: iio_write_channel_raw() ->
iio_write_channel_attribute() -> iio_channel_write(), with no checks
in place to ensure val is non-zero.

Cc: stable@vger.kernel.org
Fixes: 7b8d045e497a ("iio: adc: ad7124: allow more than 8 channels")
Signed-off-by: Zicheng Qu <quzicheng@huawei.com>
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
Link: https://patch.msgid.link/20241022134330.574601-1-quzicheng@huawei.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7124.c