]> www.infradead.org Git - users/jedix/linux-maple.git/commit
be2net: move txcp field in be_tx_obj to eliminate holes in the struct
authorIvan Vecera <cera@cera.cz>
Tue, 10 Jul 2018 20:59:45 +0000 (22:59 +0200)
committerBrian Maly <brian.maly@oracle.com>
Sat, 11 May 2019 03:43:02 +0000 (23:43 -0400)
commitef2d11f62cfc47fa7a33afc5689759ad1e7f6feb
treeab506570595d2d0b8092eaa2e3b0f94e878b6966
parent9792fcd1e55a2235f1eb2ef706b2951e48a4159f
be2net: move txcp field in be_tx_obj to eliminate holes in the struct

Orabug: 29475071

Before patch:
struct be_tx_obj {
        u32                        db_offset;            /*     0     4 */

        /* XXX 4 bytes hole, try to pack */

        struct be_queue_info       q;                    /*     8    56 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        struct be_queue_info       cq;                   /*    64    56 */
        struct be_tx_compl_info    txcp;                 /*   120     4 */

        /* XXX 4 bytes hole, try to pack */

        /* --- cacheline 2 boundary (128 bytes) --- */
        struct sk_buff *           sent_skb_list[2048];  /*   128 16384 */
        ...
}:

After patch:
struct be_tx_obj {
        u32                        db_offset;            /*     0     4 */
        struct be_tx_compl_info    txcp;                 /*     4     4 */
        struct be_queue_info       q;                    /*     8    56 */
        /* --- cacheline 1 boundary (64 bytes) --- */
        struct be_queue_info       cq;                   /*    64    56 */
        struct sk_buff *           sent_skb_list[2048];  /*   120 16384 */
        ...
};

Signed-off-by: Ivan Vecera <cera@cera.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Reviewed-by: John Donnelly <John.p.donnelly@oracle.com>
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/emulex/benet/be.h